Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to copier profile and centralize workflows #42

Merged
merged 9 commits into from
Jan 1, 2024
Merged

Migrate to copier profile and centralize workflows #42

merged 9 commits into from
Jan 1, 2024

Conversation

nicholasmhughes
Copy link
Member

What does this PR do?

Migrate to copier profile and centralize workflows

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@codecov-commenter
Copy link

codecov-commenter commented Jan 1, 2024 •
edited
Loading

Codecov Report

Attention: 61 lines in your changes are missing coverage. Please review.

Comparison is base (9f6378f) 81.22% compared to head (c40b328) 50.04%.

❗ Current head c40b328 differs from pull request most recent head ebd0280. Consider uploading reports for the commit ebd0280 to get more accurate results

Files Patch % Lines
tests/unit/conftest.py 20.51% 31 Missing ⚠️
tests/functional/conftest.py 55.35% 25 Missing ⚠️
tests/conftest.py 40.00% 2 Missing and 1 partial ⚠️
tests/integration/conftest.py 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main      #42       +/-   ##
===========================================
- Coverage   81.22%   50.04%   -31.18%     
===========================================
  Files           5       19       +14     
  Lines         293     1007      +714     
  Branches       32       60       +28     
===========================================
+ Hits          238      504      +266     
- Misses         45      492      +447     
- Partials       10       11        +1
Flag Coverage Δ
Linux 50.04% <40.77%> (-31.18%) ⬇️
project 71.51% <100.00%> (-0.18%) ⬇️
py310 50.04% <40.77%> (-31.18%) ⬇️
py38 50.00% <40.77%> (?)
py39 50.00% <40.77%> (?)
salt_3005_4 50.00% <40.77%> (?)
salt_3006_1 ?
salt_3006_4 50.04% <40.77%> (?)
tests 45.84% <40.19%> (-47.86%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicholasmhughes nicholasmhughes merged commit 49102d0 into salt-extensions:main Jan 1, 2024
7 of 17 checks passed
@nicholasmhughes nicholasmhughes deleted the copier-profile branch January 1, 2024 14:16
@nicholasmhughes nicholasmhughes mentioned this pull request Jan 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholasmhughes @codecov-commenter